Change in flashrom[master]: lspcon, realtek_mst: move i2c bus resolution from params to i2c_helper
Attention is currently required from: Sam McNally, Angel Pons. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52405 )
Change subject: lspcon, realtek_mst: move i2c bus resolution from params to i2c_helper ......................................................................
Patch Set 7:
(2 comments)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/52405/comment/299471db_5469913c PS6, Line 36: {
style nit: The opening brace for functions should go on the next line
Done
https://review.coreboot.org/c/flashrom/+/52405/comment/ff15336e_fdecb51b PS6, Line 42: char *dev = malloc(sizeof(I2C_DEV_PREFIX));
This effectively undoes what CB:52415 did...
It must because this ultimately gets returned from i2c_buspath_from_programmer_params where the length of the path cannot be predicted if 'devpath' is given. The caller could pass a buffer to this function, but buspath_from_programmer_params would still need to heap-allocate something in order to return it.
-
Peter Marheine (Code Review)