Attention is currently required from: Sam McNally, Angel Pons.

View Change

2 comments:

• File i2c_helper_linux.c:

  • Patch Set #6, Line 36: {

    style nit: The opening brace for functions should go on the next line

    Done

  • Patch Set #6, Line 42: char *dev = malloc(sizeof(I2C_DEV_PREFIX));

    This effectively undoes what CB:52415 did...

    It must because this ultimately gets returned from i2c_buspath_from_programmer_params where the length of the path cannot be predicted if 'devpath' is given. The caller could pass a buffer to this function, but buspath_from_programmer_params would still need to heap-allocate something in order to return it.

To view, visit change 52405. To unsubscribe, or for help writing mail filters, visit settings.