Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 12:
(2 comments)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86031/comment/eba252a0_85bc1058?usp... : PS11, Line 76: since %s is deprecated
May want to modify this message to use the same language as the one below, since the reason for both […]
Okay I copied that part, so now both messages have the same second half.
https://review.coreboot.org/c/flashrom/+/86031/comment/a05d3902_a5e22303?usp... : PS11, Line 93: "We recommend using flashrom_set_progress_callback_v2 instead of deprecated API " : "because flashrom_set_progress_callback fn is deprecated and will be removed " : "in future versions.\n"
I don't think these sentences are necessary, because when we hit this condition the user will have a […]
Agree, I removed