Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.
View Change
2 comments:
File libflashrom.c:
Patch Set #11, Line 76: since %s is deprecated
May want to modify this message to use the same language as the one below, since the reason for both […]
Okay I copied that part, so now both messages have the same second half.
Patch Set #11, Line 93:
"We recommend using flashrom_set_progress_callback_v2 instead of deprecated API "
"because flashrom_set_progress_callback fn is deprecated and will be removed "
"in future versions.\n"
I don't think these sentences are necessary, because when we hit this condition the user will have a […]
Agree, I removed
To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a
Gerrit-Change-Number: 86031
Gerrit-PatchSet: 12
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Richard Hughes <richard@hughsie.com>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Richard Hughes <richard@hughsie.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Gerrit-Comment-Date: Mon, 03 Mar 2025 09:02:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>