Attention is currently required from: Angel Pons, Neill Corlett. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61288 )
Change subject: Add mediatek_i2c_spi interface. ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: Thank you for well written the patch and contribution Neill ! Could you add a man page entry as well? I made some short comments inline
File mediatek_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/61288/comment/0f998c2e_f0bcce69 PS1, Line 66: d with ret value so we know how the ioctl actually failed.
https://review.coreboot.org/c/flashrom/+/61288/comment/28679258_83228c63 PS1, Line 96: args.data->block args.data->block[1] ?
https://review.coreboot.org/c/flashrom/+/61288/comment/40e430ca_b819fd5f PS1, Line 96: args.data->block[0] just 'len' here, avoids needing to do that indirection there to check we are in fact memcpy to a heap with enough space at all times.
https://review.coreboot.org/c/flashrom/+/61288/comment/f29d3c3b_d59cbb1a PS1, Line 242: GPIO line Is this board depended? Should this perhaps become a programmer parameter if so? i.e., which gpio line to use.
-
Edward O'Callaghan (Code Review)