Attention is currently required from: Angel Pons, Neill Corlett.

View Change

5 comments:

• Patchset:

  • Patch Set #1:

    Thank you for well written the patch and contribution Neill ! Could you add a man page entry as well? I made some short comments inline

• File mediatek_i2c_spi.c:

  • Patch Set #1, Line 66: d

    with ret value so we know how the ioctl actually failed.

  • Patch Set #1, Line 96: args.data->block

    args.data->block[1] ?

  • Patch Set #1, Line 96: args.data->block[0]

    just 'len' here, avoids needing to do that indirection there to check we are in fact memcpy to a heap with enough space at all times.

  • Patch Set #1, Line 242: GPIO line

    Is this board depended? Should this perhaps become a programmer parameter if so? i.e., which gpio line to use.

To view, visit change 61288. To unsubscribe, or for help writing mail filters, visit settings.