Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31223
Change subject: Fix a trivial calloc warning ......................................................................
Fix a trivial calloc warning
Change-Id: Id457c15555a6ca6333474601f92982446afa40ab Signed-off-by: Richard Hughes richard@hughsie.com --- M flashrom.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/23/31223/1
diff --git a/flashrom.c b/flashrom.c index cb2da46..e82c32e 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1461,7 +1461,7 @@ int read_flash_to_file(struct flashctx *flash, const char *filename) { unsigned long size = flash->chip->total_size * 1024; - unsigned char *buf = calloc(size, sizeof(char)); + unsigned char *buf = calloc(size, sizeof(unsigned char)); int ret = 0;
msg_cinfo("Reading flash... ");
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31223 )
Change subject: Fix a trivial calloc warning ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/31223 )
Change subject: Fix a trivial calloc warning ......................................................................
Fix a trivial calloc warning
Change-Id: Id457c15555a6ca6333474601f92982446afa40ab Signed-off-by: Richard Hughes richard@hughsie.com Reviewed-on: https://review.coreboot.org/c/31223 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M flashrom.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/flashrom.c b/flashrom.c index cb2da46..e82c32e 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1461,7 +1461,7 @@ int read_flash_to_file(struct flashctx *flash, const char *filename) { unsigned long size = flash->chip->total_size * 1024; - unsigned char *buf = calloc(size, sizeof(char)); + unsigned char *buf = calloc(size, sizeof(unsigned char)); int ret = 0;
msg_cinfo("Reading flash... ");