Change in ...flashrom[master]: Fix one more -Wmissing-field-initializers warning
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31224 Change subject: Fix one more -Wmissing-field-initializers warning ...................................................................... Fix one more -Wmissing-field-initializers warning Fixes: ichspi.c: In function ‘ich_init_spi’: ichspi.c:1707:9: warning: missing initializer for field ‘component’ Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Signed-off-by: Richard Hughes <richard@hughsie.com> --- M ichspi.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/31224/1 diff --git a/ichspi.c b/ichspi.c index 507d443..911f50a 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1704,7 +1704,7 @@ char *arg; int ich_spi_rw_restricted = 0; int desc_valid = 0; - struct ich_descriptors desc = { 0 }; + struct ich_descriptors desc; enum ich_spi_mode { ich_auto, ich_hwseq, @@ -1715,6 +1715,8 @@ ich_generation = ich_gen; ich_spibar = spibar; + memset(&desc, 0x00, sizeof(struct ich_descriptors)); + /* Moving registers / bits */ if (ich_generation == CHIPSET_100_SERIES_SUNRISE_POINT) { num_freg = 10; -- To view, visit https://review.coreboot.org/c/flashrom/+/31224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Gerrit-Change-Number: 31224 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: newchange
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31224 ) Change subject: Fix one more -Wmissing-field-initializers warning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/31224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Gerrit-Change-Number: 31224 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sun, 03 Feb 2019 19:04:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/31224 ) Change subject: Fix one more -Wmissing-field-initializers warning ...................................................................... Fix one more -Wmissing-field-initializers warning Fixes: ichspi.c: In function ‘ich_init_spi’: ichspi.c:1707:9: warning: missing initializer for field ‘component’ Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Signed-off-by: Richard Hughes <richard@hughsie.com> Reviewed-on: https://review.coreboot.org/c/31224 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> --- M ichspi.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/ichspi.c b/ichspi.c index 507d443..911f50a 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1704,7 +1704,7 @@ char *arg; int ich_spi_rw_restricted = 0; int desc_valid = 0; - struct ich_descriptors desc = { 0 }; + struct ich_descriptors desc; enum ich_spi_mode { ich_auto, ich_hwseq, @@ -1715,6 +1715,8 @@ ich_generation = ich_gen; ich_spibar = spibar; + memset(&desc, 0x00, sizeof(struct ich_descriptors)); + /* Moving registers / bits */ if (ich_generation == CHIPSET_100_SERIES_SUNRISE_POINT) { num_freg = 10; -- To view, visit https://review.coreboot.org/c/flashrom/+/31224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iee5728167963fece24822ad2e3ab7bd9d444b42c Gerrit-Change-Number: 31224 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (1)
-
Nico Huber (Code Review)