[M] Change in flashrom[master]: spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list
Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67354 )
Change subject: spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list ......................................................................
Patch Set 9:
(8 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67354/comment/3ab6a379_dfaa40a5 PS2, Line 7: spi.c: Add erasefn and opcodes for AT45 and S25F
To what? / To which lookup list?
Done
Patchset:
PS8:
Can you reorder the commits that this patch comes after the other spi. […]
Done
File spi.c:
https://review.coreboot.org/c/flashrom/+/67354/comment/94811df0_9b4e79ab PS2, Line 50: &spi_erase_at45cs_sector, 0x50},
That could work too. Given that the chip has only a single erasefunc, […]
Done
File spi.c:
https://review.coreboot.org/c/flashrom/+/67354/comment/0e9d6805_3bfbab00 PS8, Line 31: uint8_t opcode[MAX_OPCODE];
Please add a comment how the array is working
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/2737bfbb_b9709799 PS8, Line 31: [MAX_OPCODE
This can be an inline number or defined locally.
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/2da1296a_6b5d1b4e PS8, Line 49: 0x00}
Just use `0` to make clear it's a terminator
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/f0e43da9_85fcdb90 PS8, Line 70: )
Would be good to have the length of the list (`opcode_count`) as parameter. […]
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/fd750eac_7d69ac47 PS8, Line 85:
Please add documentation about the function that everyone who want's to use or work with it understa […]
Done
-
Aarya (Code Review)