Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen.
8 comments:
Commit Message:
Patch Set #2, Line 7: spi.c: Add erasefn and opcodes for AT45 and S25F
To what? / To which lookup list?
Done
Patchset:
Can you reorder the commits that this patch comes after the other spi. […]
Done
File spi.c:
Patch Set #2, Line 50: &spi_erase_at45cs_sector, 0x50},
That could work too. Given that the chip has only a single erasefunc, […]
Done
File spi.c:
Patch Set #8, Line 31: uint8_t opcode[MAX_OPCODE];
Please add a comment how the array is working
Done
Patch Set #8, Line 31: [MAX_OPCODE
This can be an inline number or defined locally.
Done
Patch Set #8, Line 49: 0x00}
Just use `0` to make clear it's a terminator
Done
Would be good to have the length of the list (`opcode_count`) as parameter. […]
Done
Please add documentation about the function that everyone who want's to use or work with it understa […]
Done
To view, visit change 67354. To unsubscribe, or for help writing mail filters, visit settings.