Change in flashrom[master]: Fix two sign-compare issues that sneaked in

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35800 )

Change subject: Fix two sign-compare issues that sneaked in
......................................................................

Fix two sign-compare issues that sneaked in

Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Signed-off-by: Nico Huber 
---
M ich_descriptors.c
M libflashrom.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/35800/1

diff --git a/ich_descriptors.c b/ich_descriptors.c
index 6d7b020..120d3fe 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -421,7 +421,7 @@
    	for (i = 0; i < nm; i++) {
    		size_t j;
    		msg_pdbg2("%-4s", master_names[i]);
-			for (j = 0; j < min(num_regions, 12); j++)
+			for (j = 0; j < (size_t)min(num_regions, 12); j++)
    			msg_pdbg2("  %c%c ",
    				  desc->master.mstr[i].read & (1 << j) ? 'r' : ' ',
    				  desc->master.mstr[i].write & (1 << j) ? 'w' : ' ');
diff --git a/libflashrom.c b/libflashrom.c
index dbc5129..1d8a9ae 100644
--- a/libflashrom.c
+++ b/libflashrom.c
@@ -139,7 +139,7 @@
  */
 struct flashrom_flashchip_info *flashrom_supported_flash_chips(void)
 {
-	int i = 0;
+	unsigned int i = 0;
    struct flashrom_flashchip_info *supported_flashchips =
    	malloc(flashchips_size * sizeof(*supported_flashchips));

Change in flashrom[master]: Fix more sign-compare issues

[Nico Huber (Code Review)]

Hello Jacob Garber, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/35800

to look at the new patch set (#2).

Change subject: Fix more sign-compare issues
......................................................................

Fix more sign-compare issues

The one in the `dummyflasher` is a little peculiar. We actually never
knew the type of the `st_size` field in `struct stat`. It happens to
be `signed` in DJGPP and `unsigned` virtually everywhere else.

Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Signed-off-by: Nico Huber 
---
M dummyflasher.c
M ich_descriptors.c
M libflashrom.c
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/35800/2

Change in flashrom[master]: Fix more sign-compare issues

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35800 )

Change subject: Fix more sign-compare issues
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c 
File ich_descriptors.c:

https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c@424 
PS2, Line 424: min
Would be nice to have a min() that didn't cast everything to int, but that can wait till later.

Change in flashrom[master]: Fix more sign-compare issues

[Nico Huber (Code Review)]

Hello Jacob Garber, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/35800

to look at the new patch set (#3).

Change subject: Fix more sign-compare issues
......................................................................

Fix more sign-compare issues

The one in the `dummyflasher` is a little peculiar. We actually never
knew the type of the `st_size` field in `struct stat`. It happens to
be `signed` in some systems (e.g. DJGPP).

Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Signed-off-by: Nico Huber 
---
M dediprog.c
M dummyflasher.c
M ich_descriptors.c
M libflashrom.c
4 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/35800/3

Change in flashrom[master]: Fix more sign-compare issues

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35800 )

Change subject: Fix more sign-compare issues
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c 
File ich_descriptors.c:

https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c@424 
PS2, Line 424: min
> Would be nice to have a min() that didn't cast everything to int, but that can wait till later.

Ack. I actually have that in another patch train, IIRC. A simple macro, though,
that is *not* double-evaluation safe. It seems impossible to implement that in
ISO C (missing `typeof`), unless we'd go for a generic template, but then
the compiler would have to be new enough...

Change in flashrom[master]: Fix more sign-compare issues

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35800 )

Change subject: Fix more sign-compare issues
......................................................................

Patch Set 3: Code-Review+2

Change in flashrom[master]: Fix more sign-compare issues

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35800 )

Change subject: Fix more sign-compare issues
......................................................................

Patch Set 3: Code-Review+2

Change in flashrom[master]: Fix more sign-compare issues

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35800 )

Change subject: Fix more sign-compare issues
......................................................................

Fix more sign-compare issues

The one in the `dummyflasher` is a little peculiar. We actually never
knew the type of the `st_size` field in `struct stat`. It happens to
be `signed` in some systems (e.g. DJGPP).

Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/35800
Tested-by: build bot (Jenkins) 
Reviewed-by: Jacob Garber 
Reviewed-by: Patrick Georgi 
---
M dediprog.c
M dummyflasher.c
M ich_descriptors.c
M libflashrom.c
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Jacob Garber: Looks good to me, approved

diff --git a/dediprog.c b/dediprog.c
index fbd6930..e4124b0 100644
--- a/dediprog.c
+++ b/dediprog.c
@@ -1038,7 +1038,7 @@
    		free(device);
    		return 1;
    	}
-		if (usedevice < 0 || usedevice > UINT_MAX) {
+		if (usedevice < 0 || usedevice > INT_MAX) {
    		msg_perr("Error: Value for 'device' is out of range.\n");
    		free(device);
    		return 1;
diff --git a/dummyflasher.c b/dummyflasher.c
index 2d7fa85..b9f6126 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -387,7 +387,7 @@
    if (!stat(emu_persistent_image, &image_stat)) {
    	msg_pdbg("Found persistent image %s, %jd B ",
    		 emu_persistent_image, (intmax_t)image_stat.st_size);
-		if (image_stat.st_size == emu_chip_size) {
+		if ((uintmax_t)image_stat.st_size == emu_chip_size) {
    		msg_pdbg("matches.\n");
    		msg_pdbg("Reading %s\n", emu_persistent_image);
    		if (read_buf_from_file(flashchip_contents, emu_chip_size,
diff --git a/ich_descriptors.c b/ich_descriptors.c
index 6d7b020..120d3fe 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -421,7 +421,7 @@
    	for (i = 0; i < nm; i++) {
    		size_t j;
    		msg_pdbg2("%-4s", master_names[i]);
-			for (j = 0; j < min(num_regions, 12); j++)
+			for (j = 0; j < (size_t)min(num_regions, 12); j++)
    			msg_pdbg2("  %c%c ",
    				  desc->master.mstr[i].read & (1 << j) ? 'r' : ' ',
    				  desc->master.mstr[i].write & (1 << j) ? 'w' : ' ');
diff --git a/libflashrom.c b/libflashrom.c
index dbc5129..1d8a9ae 100644
--- a/libflashrom.c
+++ b/libflashrom.c
@@ -139,7 +139,7 @@
  */
 struct flashrom_flashchip_info *flashrom_supported_flash_chips(void)
 {
-	int i = 0;
+	unsigned int i = 0;
    struct flashrom_flashchip_info *supported_flashchips =
    	malloc(flashchips_size * sizeof(*supported_flashchips));