View Change
1 comment:
File ich_descriptors.c:
Patch Set #2, Line 424: min
Would be nice to have a min() that didn't cast everything to int, but that can wait till later.
Ack. I actually have that in another patch train, IIRC. A simple macro, though,
that is *not* double-evaluation safe. It seems impossible to implement that in
ISO C (missing `typeof`), unless we'd go for a generic template, but then
the compiler would have to be new enough...
To view, visit change 35800. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If36ba22606021400b385ea6083eacc7b360c20c5
Gerrit-Change-Number: 35800
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 04 Oct 2019 16:55:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-MessageType: comment