Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61897 )
Change subject: libflashrom,linux_mtd: add linux_mtd writeprotect support ......................................................................
Patch Set 36:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61897/comment/6e1a4461_b01e7fab PS36, Line 10: and uses it support
Maybe instead "and uses it support" -> "and uses the framework to support".
Done
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/61897/comment/8ac26c96_ac518582 PS36, Line 380: if ((cfg->range.len == 0) != (cfg->mode != FLASHROM_WP_MODE_DISABLED)) { : return FLASHROM_WP_ERR_OTHER; : }
Please help me, I spent some time staring at the code, also reading the comment above and commit mes […]
Good catch! I think this was a last minute rewrite from `cfg->mode != FLASHROM_WP_MODE_HARDWARE` where I didn't change the operator.