Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #36, Line 10: and uses it support

    Maybe instead "and uses it support" -> "and uses the framework to support".

    Done

• File linux_mtd.c:

  • Patch Set #36, Line 380:

    	if ((cfg->range.len == 0) != (cfg->mode != FLASHROM_WP_MODE_DISABLED)) {
    		return FLASHROM_WP_ERR_OTHER;
    	}
    

    Please help me, I spent some time staring at the code, also reading the comment above and commit mes […]

    Good catch! I think this was a last minute rewrite from `cfg->mode != FLASHROM_WP_MODE_HARDWARE` where I didn't change the operator.

To view, visit change 61897. To unsubscribe, or for help writing mail filters, visit settings.