Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67664 )
Change subject: tests: add basic lifecycle test for ch341a_spi ......................................................................
Patch Set 9:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67664/comment/995b9f45_5dd71834 PS9, Line 8: If you could add test scenarios in commit message, that would be great. I know you run a few:
1) running test normally -> test pass 2) disabling the programmer ch341_spi -> test skipped, the rest of tests run normally 3) running with no libusb installed -> 3 tests skipped (dediprog, raiden_debug, ch341a), the rest of tests run normally
File tests/ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/67664/comment/c1ede016_424cdfb4 PS5, Line 22: transfer->status = LIBUSB_TRANSFER_COMPLETED; : transfer->actual_length = transfer->length; : transfer->callback(transfer);
Finally, I've wrote :D
Marking as resolved!
File tests/libusb_wraps.c:
PS5:
Okay I agree on that. Let's say we are introducing this as a default approach from now on. […]
Looks like you are ready to split the patch?
https://review.coreboot.org/c/flashrom/+/67664/comment/5c146483_33c0e555 PS5, Line 39: /* https://libusb.sourceforge.io/api-1.0/group__libusb__lib.html#ga5f8376b7a863... */
Alright, thank you! I will just mark this unresolved so that you won't forget to remove links at the […]
I think the time has come, you can remove those
-
Anastasia Klimchuk (Code Review)