Attention is currently required from: Felix Singer, Thomas Heijligen, Alexander Goncharov.

View Change

4 comments:

• Commit Message:

  • Patch Set #9, Line 8:

    If you could add test scenarios in commit message, that would be great. I know you run a few:

    1) running test normally -> test pass
    2) disabling the programmer ch341_spi -> test skipped, the rest of tests run normally
    3) running with no libusb installed -> 3 tests skipped (dediprog, raiden_debug, ch341a), the rest of tests run normally

• File tests/ch341a_spi.c:

  • Patch Set #5, Line 22:

    	transfer->status = LIBUSB_TRANSFER_COMPLETED;
    	transfer->actual_length = transfer->length;
    	transfer->callback(transfer);
    

    Finally, I've wrote :D

    Marking as resolved!

• File tests/libusb_wraps.c:

  • Patch Set #5:

    Okay I agree on that. Let's say we are introducing this as a default approach from now on. […]

    Looks like you are ready to split the patch?

  • Patch Set #5, Line 39: /* https://libusb.sourceforge.io/api-1.0/group__libusb__lib.html#ga5f8376b7a863a5a8d5b8824feb8a427a8 */

    Alright, thank you! I will just mark this unresolved so that you won't forget to remove links at the […]

    I think the time has come, you can remove those

To view, visit change 67664. To unsubscribe, or for help writing mail filters, visit settings.