Attention is currently required from: Miklós Márton, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236 )
Change subject: meson: Add support for ni845x_spi on Windows ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
Thomas, I wanted to check, is CB:74963 still needed? This patch seems to solve the same task? (or mo […]
yes, this chain fixes all ni845x problems, inclusive the changes of CB:74963
PS4: Need testing: what if the include path is not available under windows? will it just ignore the non existing path?
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/75236/comment/f737d70a_7e21632a PS4, Line 19: * Define it just here, since this driver will only work on 32-bit Windows.
Does it make any more sense to make the build system define this? I believe NI assume that you're bu […]
I've to dig deeper into this macro to figure out when it's set from the compiler. But I would move this to an other patchset.
-
Thomas Heijligen (Code Review)