Attention is currently required from: Miklós Márton, Anastasia Klimchuk, Peter Marheine.
View Change
3 comments:
Patchset:
Patch Set #4:
Thomas, I wanted to check, is CB:74963 still needed? This patch seems to solve the same task? (or mo […]
yes, this chain fixes all ni845x problems, inclusive the changes of CB:74963
Patch Set #4:
Need testing: what if the include path is not available under windows? will it just ignore the non existing path?
File ni845x_spi.c:
Patch Set #4, Line 19: * Define it just here, since this driver will only work on 32-bit Windows.
Does it make any more sense to make the build system define this? I believe NI assume that you're bu […]
I've to dig deeper into this macro to figure out when it's set from the compiler. But I would move this to an other patchset.
To view, visit change 75236. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973
Gerrit-Change-Number: 75236
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Fri, 19 May 2023 07:34:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment