Attention is currently required from: Dmitry Zhadinets.
Peter Marheine has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87047?usp=email )
Change subject: libflashrom: Add set log level functionality
......................................................................
Patch Set 6:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/87047/comment/9ff9e5a1_eb94b135?usp... :
PS6, Line 36: enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
It doesn't look like this needs external linkage, so it should be `static`.
```suggestion
static enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
```
--
To view, visit
https://review.coreboot.org/c/flashrom/+/87047?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64
Gerrit-Change-Number: 87047
Gerrit-PatchSet: 6
Gerrit-Owner: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: NyeonWoo Kim
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Dmitry Zhadinets
dzhadinets@gmail.com
Gerrit-Comment-Date: Mon, 31 Mar 2025 22:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No