Attention is currently required from: Dmitry Zhadinets.
View Change
1 comment:
File libflashrom.c:
Patch Set #6, Line 36: enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
It doesn't look like this needs external linkage, so it should be `static`.
```suggestion
static enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
```
To view, visit change 87047. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64
Gerrit-Change-Number: 87047
Gerrit-PatchSet: 6
Gerrit-Owner: Dmitry Zhadinets <dzhadinets@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: NyeonWoo Kim
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Dmitry Zhadinets <dzhadinets@gmail.com>
Gerrit-Comment-Date: Mon, 31 Mar 2025 22:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No