[S] Change in flashrom[master]: tests/selfcheck.c: Fix on non-x86 machines - flashrom-gerrit

12 Dec 2022


      Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70554 )
Change subject: tests/selfcheck.c: Fix on non-x86 machines
......................................................................
Patch Set 2:
(1 comment)
File tests/selfcheck.c:
https://review.coreboot.org/c/flashrom/+/70554/comment/6b332367_ebb879fe 
PS2, Line 142: 	assert_true(board_matches_size > 1);
Maybe it should be `> 0` unconditionally then?
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/thir...
I guess I added the check to assert that we aren't accessing invalid memory on the next line, I dont know why I used 1 instead of zero though.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/70554
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icbe677d3ef164e998daf898ddbea34f96246677f
Gerrit-Change-Number: 70554
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Evan Benn evanbenn@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 12 Dec 2022 00:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment