Attention is currently required from: Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• File tests/selfcheck.c:

  • Patch Set #2, Line 142: assert_true(board_matches_size > 1);

    Maybe it should be `> 0` unconditionally then?

    https://source.chromium.org/chromiumos/chromiumos/codesearch/+/HEAD:src/third_party/flashrom/board_enable.c;l=2530

    I guess I added the check to assert that we aren't accessing invalid memory on the next line, I dont know why I used 1 instead of zero though.

To view, visit change 70554. To unsubscribe, or for help writing mail filters, visit settings.