Angel Pons has posted comments on this change. ( https://review.coreboot.org/28813 )
Change subject: flashchips: Add Sanyo LE25FU206/A and LE25FU106B ......................................................................
Patch Set 3:
(10 comments)
Patch Set 2:
(9 comments)
Needs many fixes and retesting I guess.
Marked the chips as untested because of this.
https://review.coreboot.org/#/c/28813/2/flashchips.h File flashchips.h:
https://review.coreboot.org/#/c/28813/2/flashchips.h@609 PS2, Line 609:
The chip doesn't support the three byte RDID, 0x62 is just the […]
Cut to 0x1D
https://review.coreboot.org/#/c/28813/2/flashchips.h@610 PS2, Line 610: #define SANYO_LE25FW406 0x07 /* RES2 */
same here, I guess
Cut to 0x44
https://review.coreboot.org/#/c/28813/2/flashchips.h@611 PS2, Line 611: #define SANYO_LE25FW418A 0x10 /* RES2 and some weird 1 byte RDID variant */
0x0612 please
Zero-extended
https://review.coreboot.org/#/c/28813/2/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/28813/2/flashchips.c@11628 PS2, Line 11628: {
datasheet suggests res2
Done
https://review.coreboot.org/#/c/28813/2/flashchips.c@11632 PS2, Line 11632: .manufacture_id = PMC_ID_NOPREFIX,
The datasheet I'm reading suggests 4KiB sectors... wrote a mail.
Any news?
https://review.coreboot.org/#/c/28813/2/flashchips.c@11649 PS2, Line 11649: .eraseblocks = { {64 * 1024, 1} },
missing tab
Done
https://review.coreboot.org/#/c/28813/2/flashchips.c@11656 PS2, Line 11656: },
datasheet suggests WRSR_WREN
Done
https://review.coreboot.org/#/c/28813/2/flashchips.c@11658 PS2, Line 11658: {
same here
Done
https://review.coreboot.org/#/c/28813/2/flashchips.c@11673 PS2, Line 11673: .eraseblocks = { {4 * 1024, 64} }, : .block_erase = erase_sector_jedec,
Datasheet suggests the same register layout as for 106B?
Done
https://review.coreboot.org/#/c/28813/2/flashchips.c@11685 PS2, Line 11685: .read = read_memmapped,
Judging from the similarity to the 25FU406C id (0x0612 / 0x0613), […]
Done
-
Angel Pons (Code Review)