Attention is currently required from: Felix Singer, Edward O'Callaghan.
Alex Badea has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73037 )
Change subject: asm106x: add programmer for ASM106x SATA controllers ......................................................................
Patch Set 5:
(4 comments)
File asm106x.c:
https://review.coreboot.org/c/flashrom/+/73037/comment/28979ba0_6e8ab1dc PS5, Line 47: x
Please use `inttype.h` macros here for fixed length integer. […]
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/e57001dd_67fb5358 PS5, Line 57: msg_pdbg("asm106x timed out, ctrl 0x%02x\n", val);
Same here `... […]
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/8cb52f6a_f79995ab PS5, Line 81: msg_pdbg2("asm106x write 0x%08x chunk %u\n", val, chunk);
`write %#08"PRIx32" chunk`
Done
https://review.coreboot.org/c/flashrom/+/73037/comment/3e0189e2_ed0b7364 PS5, Line 99: msg_pdbg2("asm106x read 0x%08x chunk %u\n", val, chunk);
`read %#08"PRIx32" chunk`
Done