Attention is currently required from: Felix Singer, Edward O'Callaghan.
View Change
4 comments:
File asm106x.c:
Patch Set #5, Line 47: x
Please use `inttype.h` macros here for fixed length integer. […]
Done
Patch Set #5, Line 57: msg_pdbg("asm106x timed out, ctrl 0x%02x\n", val);
Same here `... […]
Done
Patch Set #5, Line 81: msg_pdbg2("asm106x write 0x%08x chunk %u\n", val, chunk);
`write %#08"PRIx32" chunk`
Done
Patch Set #5, Line 99: msg_pdbg2("asm106x read 0x%08x chunk %u\n", val, chunk);
`read %#08"PRIx32" chunk`
Done
To view, visit change 73037. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I591b117be911bdb8249247c20530c1cf70f6e70d
Gerrit-Change-Number: 73037
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Badea <vamposdecampos@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Comment-Date: Thu, 16 Feb 2023 06:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Gerrit-MessageType: comment