Attention is currently required from: Nico Huber, Miklós Márton, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56637 )
Change subject: ni845x_spi: Fix signed - unsigned comparisons
......................................................................
Patch Set 1:
(2 comments)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/56637/comment/9582fb63_3b0f3859
PS1, Line 556: CS_number = CS_str[0] - '0';
That's not a problem though, is it? These are just numbers in C. It might […]
Is underflow behavior defined for `unsigned char`?
https://review.coreboot.org/c/flashrom/+/56637/comment/d6659230_f79066b4
PS1, Line 556: CS_number = CS_str[0] - '0';
: free(CS_str);
: if (strlen(CS_str) > 1 || 7 < CS_number) {
: msg_perr("Only CS 0-7 supported\n");
: return 1;
: }
I would just use strtoul() TBH :)
It's simpler, sounds good.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56637
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I48ef927aa28433fb0e3b3a1f3fb2e797095e53bd
Gerrit-Change-Number: 56637
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 17 Aug 2021 10:56:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment