Attention is currently required from: Nico Huber, Miklós Márton, Anastasia Klimchuk.

View Change

2 comments:

• File ni845x_spi.c:

  • Patch Set #1, Line 556: CS_number = CS_str[0] - '0';

    That's not a problem though, is it? These are just numbers in C. It might […]

    Is underflow behavior defined for `unsigned char`?

  • Patch Set #1, Line 556:

    CS_number = CS_str[0] - '0';
    		free(CS_str);
    		if (strlen(CS_str) > 1 || 7 < CS_number) {
    			msg_perr("Only CS 0-7 supported\n");
    			return 1;
    		}
    

    I would just use strtoul() TBH :)

    It's simpler, sounds good.

To view, visit change 56637. To unsubscribe, or for help writing mail filters, visit settings.