Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine.
Piotr Halama has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73513 )
Change subject: flashchips: Add support for Boya BY25D80A ......................................................................
Patch Set 5:
(4 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/73513/comment/9c2c8699_e01da067 PS2, Line 3533: .
Ack, thanks for catching. […]
Done
https://review.coreboot.org/c/flashrom/+/73513/comment/03021e31_960be4b0 PS2, Line 3546: {2 * 1024, 512
The datasheet says: `{4 * 1024, 256}` for the first eraser.
Done
https://review.coreboot.org/c/flashrom/+/73513/comment/9f57d8f0_73abe214 PS2, Line 3549: 16 * 1024, 64
The Datasheet says {32 * 1024, 32} for the `52` block eraser.
Done
https://review.coreboot.org/c/flashrom/+/73513/comment/94520833_a1f9644f PS2, Line 3552: {32 * 1024, 32}
The datasheet says `{64 * 1024. 16}` for the `D8` block eraser.
Shouldn't it be `{16 * 1024. 64}`? I've updated `D8` to `{16 * 1024. 64}`
-
Piotr Halama (Code Review)