Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine.
View Change
4 comments:
File flashchips.c:
Patch Set #2, Line 3533: .
Ack, thanks for catching. […]
Done
Patch Set #2, Line 3546: {2 * 1024, 512
The datasheet says: `{4 * 1024, 256}` for the first eraser.
Done
Patch Set #2, Line 3549: 16 * 1024, 64
The Datasheet says {32 * 1024, 32} for the `52` block eraser.
Done
Patch Set #2, Line 3552: {32 * 1024, 32}
The datasheet says `{64 * 1024. 16}` for the `D8` block eraser.
Shouldn't it be `{16 * 1024. 64}`? I've updated `D8` to `{16 * 1024. 64}`
To view, visit change 73513. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I586f3455d925132bbda3fccdad00f0b1e22c2ea7
Gerrit-Change-Number: 73513
Gerrit-PatchSet: 5
Gerrit-Owner: Piotr Halama <skrzynka@halamix2.pl>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Thu, 09 Mar 2023 20:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment