Attention is currently required from: Nico Huber, Angel Pons, Light, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63130 )
Change subject: pony_spi.c: Extract out get_params to simplify init ......................................................................
Patch Set 3:
(6 comments)
File pony_spi.c:
https://review.coreboot.org/c/flashrom/+/63130/comment/c0fe3ba7_6f04244e PS3, Line 153: {
nit: add space before opening brace
Done
https://review.coreboot.org/c/flashrom/+/63130/comment/75b443bb_db815a82 PS3, Line 167: bool have_device;
From my point of view: Review doesn't scale well with the size of […]
The concept here was that the function type-sigture was the new invariant, mathematically speaking, and therefore call logic is modified to inhabit the new type hence considering the change atomic.
I do understand what you are saying however "small change" has a certain amount of perspective variability to it. In any case, this was just meant to be a quick cleanup so I reverted leave it as it was for the sake of reviewers.
https://review.coreboot.org/c/flashrom/+/63130/comment/11b81eb8_efb06393 PS3, Line 171: return 1;
If the `dev` parameter is correct (i.e. […]
Done. serialport could do with a better internal API from the looks of it.
https://review.coreboot.org/c/flashrom/+/63130/comment/d975a0e2_a9d9ae42 PS3, Line 181: return 1;
Serial port can also leak here.
Done
https://review.coreboot.org/c/flashrom/+/63130/comment/e1fa8357_0c13217f PS3, Line 232: true
This is unrelated. Please do it in a separate commit.
Done
https://review.coreboot.org/c/flashrom/+/63130/comment/bc503d5f_20594b5c PS3, Line 237: true
Ditto
Done
-
Edward O'Callaghan (Code Review)