Attention is currently required from: Nico Huber, Angel Pons, Light, Anastasia Klimchuk.

View Change

6 comments:

• File pony_spi.c:

  • Patch Set #3, Line 153: {

    nit: add space before opening brace

    Done

  • Patch Set #3, Line 167: bool have_device;

    > From my point of view: Review doesn't scale well with the size of […]

    The concept here was that the function type-sigture was the new invariant, mathematically speaking, and therefore call logic is modified to inhabit the new type hence considering the change atomic.

    I do understand what you are saying however "small change" has a certain amount of perspective variability to it. In any case, this was just meant to be a quick cleanup so I reverted leave it as it was for the sake of reviewers.

  • Patch Set #3, Line 171: return 1;

    If the `dev` parameter is correct (i.e. […]

    Done. serialport could do with a better internal API from the looks of it.

  • Patch Set #3, Line 181: return 1;

    Serial port can also leak here.

    Done

  • Patch Set #3, Line 232: true

    This is unrelated. Please do it in a separate commit.

    Done

  • Patch Set #3, Line 237: true

    Ditto

    Done

To view, visit change 63130. To unsubscribe, or for help writing mail filters, visit settings.