Attention is currently required from: Robert Zieba, Nico Huber, Diana Zigterman, Edward O'Callaghan, Karthik Ramasubramanian. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62909 )
Change subject: raiden_debug_spi: Add more informative error message when WP is enabled ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/62909/comment/dfd31704_1326f1c4 PS3, Line 987: trailing space
https://review.coreboot.org/c/flashrom/+/62909/comment/5149acf3_9dcd3477 PS3, Line 987: /* Check if we received an error from the device. An error will have no response : data, just the packet_id and status_code. */ We follow coding style https://www.flashrom.org/Development_Guidelines#Coding_style which is for the multi-line comment like this would be
/* * Check if we received an error from the device. An error will have no response * data, just the packet_id and status_code. */
Keep an eye to remove all trailing spaces, they often sneak in after first /*
https://review.coreboot.org/c/flashrom/+/62909/comment/5a323ab7_8f3de752 PS3, Line 989: trailing space
https://review.coreboot.org/c/flashrom/+/62909/comment/eefb8852_1da803bc PS3, Line 990: sizeof(struct usb_spi_response_v2) - USB_SPI_PAYLOAD_SIZE_V2_RESPONSE && : rsp_config.packet_v2.rsp_start.status_code != USB_SPI_SUCCESS) { Could you please add one more tab before these two lines? It would be easier to visually distinguish between if condition and body. There is another if condition just above this one, which uses the same formatting approach.