Attention is currently required from: Robert Zieba, Nico Huber, Diana Zigterman, Edward O'Callaghan, Karthik Ramasubramanian.

Patch set 3:Code-Review +1

View Change

4 comments:

• File raiden_debug_spi.c:

  • Patch Set #3, Line 987:

    trailing space

  • Patch Set #3, Line 987:

    		/* Check if we received an error from the device. An error will have no response 
    		   data, just the packet_id and status_code. */
    

    We follow coding style https://www.flashrom.org/Development_Guidelines#Coding_style which is for the multi-line comment like this would be

     /*
      * Check if we received an error from the device. An error will have no response
      * data, just the packet_id and status_code. 
      */

    Keep an eye to remove all trailing spaces, they often sneak in after first /*

  • Patch Set #3, Line 989:

    trailing space

  • Patch Set #3, Line 990:

    sizeof(struct usb_spi_response_v2) - USB_SPI_PAYLOAD_SIZE_V2_RESPONSE &&
    			rsp_config.packet_v2.rsp_start.status_code != USB_SPI_SUCCESS) {
    

    Could you please add one more tab before these two lines? It would be easier to visually distinguish between if condition and body.
    There is another if condition just above this one, which uses the same formatting approach.

To view, visit change 62909. To unsubscribe, or for help writing mail filters, visit settings.