Attention is currently required from: Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62324 )
Change subject: tests/chips.c: Mock out open() for lock file ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62324/comment/9bc059c6_eaac502c PS3, Line 7: out You can remove "out". Just "Mock open() for all chip tests". And as a commit description, I would add info that it's a lock file which needs to be opened.
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/62324/comment/588c6807_dd48e1d3 PS3, Line 189: #define DEFAULT_MOCK_FD 0xC0FE Whatever will be end result in CB:62319 ideally it can be reused here
https://review.coreboot.org/c/flashrom/+/62324/comment/7aa3ab48_97db7277 PS3, Line 212: data Similarly as in previous patch, this can be `erase_chip_io_state` and same for the rest of the patch.
https://review.coreboot.org/c/flashrom/+/62324/comment/8ff49ced_507f66ac PS3, Line 213: "/run/lock/flashrom_lock" If this is exactly identical path for all the chip tests, can be a macro in this file?
https://review.coreboot.org/c/flashrom/+/62324/comment/906bbe86_c6520308 PS3, Line 222: io_mock_register(&chip_io); You need to do `io_mock_register(NULL);` at the end of test, like verify tests do.
-
Anastasia Klimchuk (Code Review)