Attention is currently required from: Edward O'Callaghan.

View Change

5 comments:

• Commit Message:

  • Patch Set #3, Line 7: out

    You can remove "out". Just "Mock open() for all chip tests".
    And as a commit description, I would add info that it's a lock file which needs to be opened.

• File tests/chip.c:

  • Patch Set #3, Line 189: #define DEFAULT_MOCK_FD 0xC0FE

    Whatever will be end result in CB:62319 ideally it can be reused here

  • Patch Set #3, Line 212: data

    Similarly as in previous patch, this can be `erase_chip_io_state` and same for the rest of the patch.

  • Patch Set #3, Line 213: "/run/lock/flashrom_lock"

    If this is exactly identical path for all the chip tests, can be a macro in this file?

  • Patch Set #3, Line 222: io_mock_register(&chip_io);

    You need to do `io_mock_register(NULL);` at the end of test, like verify tests do.

To view, visit change 62324. To unsubscribe, or for help writing mail filters, visit settings.