Attention is currently required from: Daniel Campello, Light. Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64668 )
Change subject: cli_output.c: Format progress output to show in single line ......................................................................
Patch Set 1:
(2 comments)
File cli_output.c:
https://review.coreboot.org/c/flashrom/+/64668/comment/307a03bd_a99bab11 PS1, Line 88: msg_ginfo("\r[%s] %u%% complete... ", flashrom_progress_stage_to_string(progress_state->stage), pc); How does this \r interact with other messages from other sources?
eg: msg_ginfo("\r[%s] %u%% complete") msg_gerror("important information") msg_ginfo("\r[%s] %u%% complete")
https://review.coreboot.org/c/flashrom/+/64668/comment/7c79a67f_9773f694 PS1, Line 89: } I would assume \r is only appropriate for interactive usage. Is any mechanism already implemented for detecting interactive usage? EG. isatty?
If using isatty, terminal escape sequences may be a better choice (or they might not, I'm not sure). EG: https://chromium-review.googlesource.com/c/external/repo/+/3592792
-
Evan Benn (Code Review)