Attention is currently required from: Daniel Campello, Light.

View Change

2 comments:

• File cli_output.c:

  • Patch Set #1, Line 88: msg_ginfo("\r[%s] %u%% complete... ", flashrom_progress_stage_to_string(progress_state->stage), pc);

    How does this \r interact with other messages from other sources?

    eg:
    msg_ginfo("\r[%s] %u%% complete")
    msg_gerror("important information")
    msg_ginfo("\r[%s] %u%% complete")

  • Patch Set #1, Line 89: }

    I would assume \r is only appropriate for interactive usage. Is any mechanism already implemented for detecting interactive usage? EG. isatty?

    If using isatty, terminal escape sequences may be a better choice (or they might not, I'm not sure). EG: https://chromium-review.googlesource.com/c/external/repo/+/3592792

To view, visit change 64668. To unsubscribe, or for help writing mail filters, visit settings.