Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58480 )
Change subject: flashchips,writeprotect_ranges: add range decoding function ......................................................................
Patch Set 10:
(4 comments)
File flash.h:
https://review.coreboot.org/c/flashrom/+/58480/comment/66cd25fd_b76a7afb PS10, Line 202: range_decode_fn_t In this typedef wp_ prefix would be informative. And to save some line length, you can omit cfg and range param names, they are self-explanatory from param types.
https://review.coreboot.org/c/flashrom/+/58480/comment/43c08639_b507f3e0 PS10, Line 319: decode_range If typedef gets wp_ prefix, this name can be decode_wp_range.
File writeprotect_ranges.c:
https://review.coreboot.org/c/flashrom/+/58480/comment/1c0641a9_b19275a1 PS10, Line 19: ithat typo
https://review.coreboot.org/c/flashrom/+/58480/comment/8c98bccb_c410ecfa PS10, Line 40: range->chip_len; Same as Sergii said, chip_len doesn't seem to belong to range. It should be possible to have it as decode_range_w25 function argument, right? (I still think chip pointer is not needed in wp_chip_config)
-
Anastasia Klimchuk (Code Review)