Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

View Change

4 comments:

• File flash.h:

  • Patch Set #10, Line 202: range_decode_fn_t

    In this typedef wp_ prefix would be informative. And to save some line length, you can omit cfg and range param names, they are self-explanatory from param types.

  • Patch Set #10, Line 319: decode_range

    If typedef gets wp_ prefix, this name can be decode_wp_range.

• File writeprotect_ranges.c:

  • Patch Set #10, Line 19: ithat

    typo

  • Patch Set #10, Line 40: range->chip_len;

    Same as Sergii said, chip_len doesn't seem to belong to range. It should be possible to have it as decode_range_w25 function argument, right?
    (I still think chip pointer is not needed in wp_chip_config)

To view, visit change 58480. To unsubscribe, or for help writing mail filters, visit settings.