Nico Huber has posted comments on this change. ( https://review.coreboot.org/25706 )
Change subject: linux_mtd: Initial import ......................................................................
Patch Set 8: Code-Review+2
(5 comments)
https://review.coreboot.org/#/c/25706/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/25706/8//COMMIT_MSG@7 PS8, Line 7: linux_mtd: Initial import Paul asked to make this a statement and I generally agree. How about "Import driver from CrOS"?
https://review.coreboot.org/#/c/25706/8//COMMIT_MSG@17 PS8, Line 17: it for other Linux interfaces later on. Maybe also mention the switch to stream functions.
https://review.coreboot.org/#/c/25706/8/flashrom.8.tmpl File flashrom.8.tmpl:
PS8: There's also the automation for `-p internal`.
https://review.coreboot.org/#/c/25706/8/flashrom.8.tmpl@1014 PS8, Line 1014: You have to specify the MTD device to use with the AIUI, this is optional (it would try to open /dev/mtd0 by default)?
https://review.coreboot.org/#/c/25706/8/linux_mtd.c File linux_mtd.c:
https://review.coreboot.org/#/c/25706/8/linux_mtd.c@16 PS8, Line 16: #include <ctype.h> : #include <errno.h> : #include <fcntl.h> : #include <inttypes.h> : #include <libgen.h> : #include <stdio.h> : #include <stdlib.h> : #include <mtd/mtd-user.h> : #include <string.h> : #include <sys/ioctl.h> : #include <sys/stat.h> : #include <unistd.h> Not sure, if we (still) need all of these.
-
Nico Huber (Code Review)