Patch set 8:Code-Review +2

View Change

5 comments:

• Commit Message:

  • Patch Set #8, Line 7: linux_mtd: Initial import

    Paul asked to make this a statement and I generally agree.
    How about "Import driver from CrOS"?

  • Patch Set #8, Line 17: it for other Linux interfaces later on.

    Maybe also mention the switch to stream functions.

• File flashrom.8.tmpl:

  • Patch Set #8:

    There's also the automation for `-p internal`.

  • Patch Set #8, Line 1014: You have to specify the MTD device to use with the

    AIUI, this is optional (it would try to open /dev/mtd0 by default)?

• File linux_mtd.c:

  • Patch Set #8, Line 16:

    #include <ctype.h>
    #include <errno.h>
    #include <fcntl.h>
    #include <inttypes.h>
    #include <libgen.h>
    #include <stdio.h>
    #include <stdlib.h>
    #include <mtd/mtd-user.h>
    #include <string.h>
    #include <sys/ioctl.h>
    #include <sys/stat.h>
    #include <unistd.h>
    

    Not sure, if we (still) need all of these.

To view, visit change 25706. To unsubscribe, or for help writing mail filters, visit settings.