Attention is currently required from: Antonio Vázquez Blanco.
Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/84982?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Split usbdev declarations to a separate header. ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: Antonio, thank you for your contributions! I only have comments about commit message.
I will also review other patches a bit later. Appreciate your improvements!
Commit Message:
https://review.coreboot.org/c/flashrom/+/84982/comment/0ded5873_e31888a8?usp... : PS2, Line 7: Split I would say "Extract" instead of Split.
https://review.coreboot.org/c/flashrom/+/84982/comment/136f0c73_0c0b5099?usp... : PS2, Line 9: This is a simple refactor that aims to simplify maintenance and to clarify file dependency inside the project. : Currently, most of the declarations reside in programmer.h making it difficult to really understand file dependency. We have a max width for commit message text 72 chars https://flashrom.org/dev_guide/development_guide.html#commit-message-1
Could you please wrap the message by 72 chars? (probably in the other patches too)
-
Anastasia Klimchuk (Code Review)