Attention is currently required from: Antonio Vázquez Blanco.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
3 comments:
Patchset:
Antonio, thank you for your contributions! I only have comments about commit message.
I will also review other patches a bit later. Appreciate your improvements!
Commit Message:
Patch Set #2, Line 7: Split
I would say "Extract" instead of Split.
This is a simple refactor that aims to simplify maintenance and to clarify file dependency inside the project.
Currently, most of the declarations reside in programmer.h making it difficult to really understand file dependency.
We have a max width for commit message text 72 chars https://flashrom.org/dev_guide/development_guide.html#commit-message-1
Could you please wrap the message by 72 chars?
(probably in the other patches too)
To view, visit change 84982. To unsubscribe, or for help writing mail filters, visit settings.