Attention is currently required from: Tim Crawford, Michał Żygowski, David Hendricks.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55578 )
Change subject: Add Tiger Lake U Premium support
......................................................................
Patch Set 13:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/55578/comment/8ae227ef_04a939a4
PS13, Line 1016: if (content->CSSL != 0x11)
AIUI, David's wants an explicit check+return for each platform. So this should become
something like
if (...)
return TIGER_POINT;
warn;
return TIGER_POINT;
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55578
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd
Gerrit-Change-Number: 55578
Gerrit-PatchSet: 13
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Comment-Date: Wed, 03 Nov 2021 15:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment