Attention is currently required from: Tim Crawford, Michał Żygowski, David Hendricks.
View Change
1 comment:
File ich_descriptors.c:
Patch Set #13, Line 1016: if (content->CSSL != 0x11)
AIUI, David's wants an explicit check+return for each platform. So this should become
something like
if (...)
return TIGER_POINT;
warn;
return TIGER_POINT;
To view, visit change 55578. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd
Gerrit-Change-Number: 55578
Gerrit-PatchSet: 13
Gerrit-Owner: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Tim Crawford <tcrawford@system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford@system76.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Comment-Date: Wed, 03 Nov 2021 15:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment