Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62866 )
Change subject: ichspi: Maximize usage of `ich_generation` global variable ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Like I was saying internally, we want to do the opposite of this. We want functions *not* to be a closure of the global of ich_generation.
In other words, ich_generation should be a parameter to all functions that use it.
Sure, understood, there are several instances of global variable in current ichspi.c file as below, I hope you have plan to clean that up at once
1. https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ich...
2. https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ich...
3.https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ich...
4.https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ich...
... Total there are > 10 instances of `ich_generation` global variable.
-
Subrata Banik (Code Review)