Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Like I was saying internally, we want to do the opposite of this. We want functions *not* to be a closure of the global of ich_generation.

    In other words, ich_generation should be a parameter to all functions that use it.

    Sure, understood, there are several instances of global variable in current ichspi.c file as below, I hope you have plan to clean that up at once

    1. https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ichspi.c#628

    2. https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ichspi.c#1081

    3.https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ichspi.c#1093

    4.https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/ichspi.c#1415

    ... Total there are > 10 instances of `ich_generation` global variable.

To view, visit change 62866. To unsubscribe, or for help writing mail filters, visit settings.