Change in flashrom[master]: flashrom.c: Correct "raiden_debug_spi" drv name

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48106 )

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

flashrom.c: Correct "raiden_debug_spi" drv name

Unfortantly raiden_debug was upstreamed with a slightly
incorrect name of "raiden_debug" where-as in ChromiumOS
it is known as "raiden_debug_spi" and so correct this to
align. This avoids confusion and divergence for a unified
future.

Change-Id: I0eca35863403c5d4adbe19b31801e8dfa072006f
Signed-off-by: Edward O'Callaghan 
---
M flashrom.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/48106/1

diff --git a/flashrom.c b/flashrom.c
index 630e7ea..7f5f2a8 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -147,7 +147,7 @@

#if CONFIG_RAIDEN_DEBUG_SPI == 1
    {
-		.name			= "raiden_debug",
+		.name			= "raiden_debug_spi",
    	.type			= USB,
    	.devs.dev		= devs_raiden,
    	.init			= raiden_debug_spi_init,

[Edward O'Callaghan (Code Review)]

Hello Sam McNally, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/48106

to look at the new patch set (#2).

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

flashrom.c: Correct "raiden_debug_spi" drv name

Unfortantly raiden_debug was upstreamed with a slightly
incorrect name of "raiden_debug" where-as in ChromiumOS
it is known as "raiden_debug_spi" and so correct this to
align. This avoids confusion and divergence for a unified
future.

Change-Id: I0eca35863403c5d4adbe19b31801e8dfa072006f
Signed-off-by: Edward O'Callaghan 
---
M flashrom.c
M programmer.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/48106/2

[Sam McNally (Code Review)]

Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48106 )

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48106 )

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

https://review.coreboot.org/c/flashrom/+/48106/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/48106/2//COMMIT_MSG@9 
PS2, Line 9: Unfortantly
Unfortunately

https://review.coreboot.org/c/flashrom/+/48106/2//COMMIT_MSG@10 
PS2, Line 10: where-as
whereas

[Edward O'Callaghan (Code Review)]

Hello Sam McNally, build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/48106

to look at the new patch set (#3).

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

flashrom.c: Correct "raiden_debug_spi" drv name

Unfortunately raiden_debug was upstreamed with a slightly
incorrect name of "raiden_debug" whereas in ChromiumOS
it is known as "raiden_debug_spi" and so correct this to
align. This avoids confusion and divergence for a unified
future.

Change-Id: I0eca35863403c5d4adbe19b31801e8dfa072006f
Signed-off-by: Edward O'Callaghan 
---
M flashrom.c
M programmer.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/48106/3

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48106 )

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/flashrom/+/48106/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/48106/2//COMMIT_MSG@9 
PS2, Line 9: Unfortantly
> Unfortunately

Done

https://review.coreboot.org/c/flashrom/+/48106/2//COMMIT_MSG@10 
PS2, Line 10: where-as
> whereas

Done

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48106 )

Change subject: flashrom.c: Correct "raiden_debug_spi" drv name
......................................................................

flashrom.c: Correct "raiden_debug_spi" drv name

Unfortunately raiden_debug was upstreamed with a slightly
incorrect name of "raiden_debug" whereas in ChromiumOS
it is known as "raiden_debug_spi" and so correct this to
align. This avoids confusion and divergence for a unified
future.

Change-Id: I0eca35863403c5d4adbe19b31801e8dfa072006f
Signed-off-by: Edward O'Callaghan 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/48106
Tested-by: build bot (Jenkins) 
Reviewed-by: Sam McNally 
Reviewed-by: Angel Pons 
---
M flashrom.c
M programmer.h
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, but someone else must approve
  Sam McNally: Looks good to me, approved

diff --git a/flashrom.c b/flashrom.c
index 630e7ea..7f5f2a8 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -147,7 +147,7 @@

#if CONFIG_RAIDEN_DEBUG_SPI == 1
    {
-		.name			= "raiden_debug",
+		.name			= "raiden_debug_spi",
    	.type			= USB,
    	.devs.dev		= devs_raiden,
    	.init			= raiden_debug_spi_init,
diff --git a/programmer.h b/programmer.h
index c93bf83..d66d239 100644
--- a/programmer.h
+++ b/programmer.h
@@ -47,7 +47,7 @@
    PROGRAMMER_GFXNVIDIA,
 #endif
 #if CONFIG_RAIDEN_DEBUG_SPI == 1
-	PROGRAMMER_RAIDEN,
+	PROGRAMMER_RAIDEN_DEBUG_SPI,
 #endif
 #if CONFIG_DRKAISER == 1
    PROGRAMMER_DRKAISER,