Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48204 )
Change subject: flash.h: Trivial indent fix of comment ......................................................................
flash.h: Trivial indent fix of comment
Align with the properly tab indented comment on the CrOS Flashrom side to make things consisent.
Change-Id: I09605bfec203d294077f298f8619bbc7d10cc68a Signed-off-by: Edward O'Callaghan quasisec@google.com --- M flash.h 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/48204/1
diff --git a/flash.h b/flash.h index 203d32d..a1e7669 100644 --- a/flash.h +++ b/flash.h @@ -269,9 +269,10 @@ bool verify_whole_chip; } flags; /* We cache the state of the extended address register (highest byte - of a 4BA for 3BA instructions) and the state of the 4BA mode here. - If possible, we enter 4BA mode early. If that fails, we make use - of the extended address register. */ + * of a 4BA for 3BA instructions) and the state of the 4BA mode here. + * If possible, we enter 4BA mode early. If that fails, we make use + * of the extended address register. + */ int address_high_byte; bool in_4ba_mode; };
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48204 )
Change subject: flash.h: Trivial indent fix of comment ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48204 )
Change subject: flash.h: Trivial indent fix of comment ......................................................................
flash.h: Trivial indent fix of comment
Align with the properly tab indented comment on the CrOS Flashrom side to make things consisent.
Change-Id: I09605bfec203d294077f298f8619bbc7d10cc68a Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/48204 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M flash.h 1 file changed, 4 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/flash.h b/flash.h index 203d32d..a1e7669 100644 --- a/flash.h +++ b/flash.h @@ -269,9 +269,10 @@ bool verify_whole_chip; } flags; /* We cache the state of the extended address register (highest byte - of a 4BA for 3BA instructions) and the state of the 4BA mode here. - If possible, we enter 4BA mode early. If that fails, we make use - of the extended address register. */ + * of a 4BA for 3BA instructions) and the state of the 4BA mode here. + * If possible, we enter 4BA mode early. If that fails, we make use + * of the extended address register. + */ int address_high_byte; bool in_4ba_mode; };
-
Edward O'Callaghan (Code Review) -
Frans Hendriks (Code Review)