Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54147 )
Change subject: libflashrom: clear layout on flashrom_layout_release ......................................................................
Patch Set 2:
(2 comments)
File layout.c:
https://review.coreboot.org/c/flashrom/+/54147/comment/3924dcb1_2f9d5926 PS1, Line 296: layout->entries[i].included = false;
Should this line also move into flashrom_layout_release() ?
Even better, zero the whole entry.
https://review.coreboot.org/c/flashrom/+/54147/comment/df8a188a_bab782e5 PS1, Line 279: layout_cleanup_args
This function is not cleaning up the layout anymore, only args. […]
It's still layout args specifically so I'd like to keep 'layout', but layout_args_cleanup seems a little better.